Don't include NoDisplay items, except for window identification

Searching across NoDisplay desktop items can produce weird
results to the user (including duplicates, and items that
aren't really applications at all.) So, don't include them
normally.

But continue including NoDisplay items when we look up the
desktop file for a window, since we want to catch applications
like Evince and Nautilus which are otherwise NoDisplay.

http://bugzilla.gnome.org/show_bug.cgi?id=587548

diff --git a/src/shell-app-system.c b/src/shell-app-system.c
index 50da81dfda7fab0a45736f3b2bfadcaf0617d2bb..44601c24da3accc25f1725040279ae434f187b4d 100644 (file)
--- a/src/shell-app-system.c
+++ b/src/shell-app-system.c
@@ -217,7 +217,8 @@ gather_entries_recurse (ShellAppSystem     *monitor,
             {
               GMenuTreeEntry *entry = (GMenuTreeEntry *)item;
               const char *id = gmenu_tree_entry_get_desktop_file_id (entry);
-              ids = g_slist_prepend (ids, g_strdup (id));
+              if (!gmenu_tree_entry_get_is_nodisplay (entry))
+                ids = g_slist_prepend (ids, g_strdup (id));
             }
             break;
           case GMENU_TREE_ITEM_DIRECTORY: